Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Fix toInteger() #595

Merged
merged 4 commits into from
Jul 28, 2021
Merged

Fix toInteger() #595

merged 4 commits into from
Jul 28, 2021

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Jul 26, 2021

  1. Fix incorrect result
  2. Add overflow check when parsing string

Fix vesoft-inc/nebula-graph#1284

@Aiee Aiee added the ready-for-testing PR: ready for the CI test label Jul 26, 2021
@yixinglu yixinglu merged commit f9e8a4f into vesoft-inc:master Jul 28, 2021
@Aiee Aiee deleted the fix-toInt branch July 28, 2021 02:08
CPWstatic pushed a commit to CPWstatic/nebula-common that referenced this pull request Aug 2, 2021
* Fix toInteger/toFloat parsing string

* Check toInteger() overflow when  parsing string
CPWstatic added a commit that referenced this pull request Aug 2, 2021
* Modify the return value of partId function (#591)

* fix and simplify SubscriptRangeExpression's eval (#593)

* Fix toInteger() (#595)

* Fix toInteger/toFloat parsing string

* Check toInteger() overflow when  parsing string

Co-authored-by: laura-ding <48548375+laura-ding@users.noreply.github.com>
Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>
Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.0.1 toInteger has a bug
3 participants